Summary: | WebSocket: Add fail() to WebSocketChannel and its family | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuta Kitamura <yutak> | ||||||
Component: | WebCore Misc. | Assignee: | Yuta Kitamura <yutak> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, tkent, ukai | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 35721, 61115 | ||||||||
Attachments: |
|
Description
Yuta Kitamura
2011-05-23 05:53:55 PDT
Created attachment 94411 [details]
Patch
Comment on attachment 94411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94411&action=review > Source/WebCore/websockets/ThreadableWebSocketChannel.h:56 > + virtual void fail(const String& reason) = 0; // Log the reason text and close the connection. Will call didClose(). nit: I feel such long comment should be moved to its own line. > Source/WebCore/websockets/WebSocketChannel.h:62 > + virtual void fail(const String& reason); // Log the reason text and close the connection. Will call didClose(). > virtual void disconnect(); // Will suppress didClose(). ThreadableWebSocketChannel has these comments. So we may remove them here. > Source/WebCore/websockets/WorkerThreadableWebSocketChannel.cpp:385 > + m_loaderProxy.postTaskToLoader( > + createCallbackTask(&WorkerThreadableWebSocketChannel::mainThreadFail, AllowCrossThreadAccess(m_peer), reason)); No need to break the line. (In reply to comment #2) > > Source/WebCore/websockets/WorkerThreadableWebSocketChannel.cpp:385 > > + m_loaderProxy.postTaskToLoader( > > + createCallbackTask(&WorkerThreadableWebSocketChannel::mainThreadFail, AllowCrossThreadAccess(m_peer), reason)); > > No need to break the line. Sure. I will update the same issues occurring in the same file. Created attachment 94573 [details]
Ready to commit
Comment on attachment 94573 [details] Ready to commit Clearing flags on attachment: 94573 Committed r87139: <http://trac.webkit.org/changeset/87139> All reviewed patches have been landed. Closing bug. |