Bug 61233 – sheriffbot should give more details about the failures in IRC

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

sheriffbot should give more details about the failures in IRC
Requested by abarth on #webkit.

[Adam Barth]

Created attachment 94435 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 94435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94435&action=review

> Tools/Scripts/webkitpy/tool/commands/sheriffbot.py:82
> +        failing_tests = set()

I wonder if the failure_map should know how to give us this?

> Tools/Scripts/webkitpy/tool/commands/sheriffbot.py:86
> +            failing_tests = failing_tests.union(set(failure_map.tests_failing_for(revision)))

Since we don't actually use these tests in this loop, I would have just broken it out into a separate loop.

> Tools/Scripts/webkitpy/tool/commands/sheriffbot.py:98
> +        if failing_tests:

I might have put this whole block into a helper function.

> Tools/Scripts/webkitpy/tool/commands/sheriffbot.py:100
> +            irc_message = "New failures: %s" % ", ".join(sorted(failing_tests)[0:test_list_limit])

Do you mean to skip the first test?  Either you don't need 0, or 0 is wrong.  I think you just mean [:test_list_limit].

[Adam Barth]

Created attachment 94464 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 94464 [details]
Patch

OK.

[WebKit Commit Bot]

Comment on attachment 94464 [details]
Patch

Clearing flags on attachment: 94464

Committed r87107: <http://trac.webkit.org/changeset/87107>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.