Summary: | Allow ShadowBlur to do tiling when the context is scaled | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, mdelaney7, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-05-20 19:09:33 PDT
Created attachment 94306 [details]
Patch
Attachment 94306 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/transforms/AffineTransform.h:136: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 94306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94306&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=61232 This "preservesAxisAlignment" allows scales and rotations of factors of 90 degrees. So, it avoids skews and non-axis-alignned resulting rotations. Also, don't we want to have some new test cases (pixel-only tests, likely) that add a non-integral scale and/or x*90 degree rotation to make sure there are no pixel cracks? Filed bug 61234 on possible pixel cracks with this patch. Created attachment 94310 [details]
Patch
Attachment 94310 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/box-shadow/scaled-box-sha..." exit_code: 1
Source/WebCore/platform/graphics/transforms/AffineTransform.h:136: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 94310 [details] Patch Attachment 94310 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8720506 New failing tests: fast/box-shadow/scaled-box-shadow.html Created attachment 94314 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
|