Bug 61218

Summary:

Add delegate methods about focus and blur to all elements

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit API

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, mitz

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Enrica Casucci 2011-05-20 14:42:32 PDT

http://trac.webkit.org/changeset/45723 added these delegates for form elements.
We now want to add them for all the elements.
We also need to change the delegate names from formDidFocus and formDidBlur to something less specific, like elementDidFocus and elementDidBlur.

Comment 1 Enrica Casucci 2011-05-20 14:44:22 PDT

We can afford to change these names since only the Mac implementation is using it.

Comment 2 Enrica Casucci 2011-05-20 15:11:45 PDT

Created attachment 94277 [details]
Patch

Comment 3 David Kilzer (:ddkilzer) 2011-05-20 15:17:08 PDT

Comment on attachment 94277 [details]
Patch

r=me

Comment 4 Enrica Casucci 2011-05-20 15:21:55 PDT

<rdar://problem/9365073> and <rdar://problem/9299509>

Comment 5 Enrica Casucci 2011-05-20 15:27:31 PDT

http://trac.webkit.org/changeset/86988

Comment 6 mitz 2018-10-03 21:07:39 PDT

Comment on attachment 94277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94277&action=review

> Source/WebKit/mac/WebView/WebUIDelegatePrivate.h:227
> +- (void)webView:(WebView *)sender elementDidFocusNode:(DOMNode *)node;
> +- (void)webView:(WebView *)sender elementDidBlurNode:(DOMNode *)node;

These delegate methods were renamed, but the code above in WebChromeClient.mm was never changed to call the new methods.