Summary: | Default min DOM Timer interval is not set soon enough for first page to pick it up in WK2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||
Component: | WebKit Misc. | Assignee: | Matthew Delaney <mdelaney7> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jberlin, sfalken | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Matthew Delaney
2011-05-20 14:00:24 PDT
Created attachment 94267 [details]
Patch
Comment on attachment 94267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94267&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:210 > + Settings::setDefaultMinDOMTimerInterval(0.004); Moving this early seems good, but it’s a bit strange to tuck this in between setting up the page clients and calling new Page, since the pageClients structure is really just an argument to the Page constructor. I suggest calling this even before the definition of the pageClients local variable, right after the assert. Created attachment 94268 [details]
Patch
Committed r86985: <http://trac.webkit.org/changeset/86985> |