Bug 61214
Summary: | Set project-wide DOMTimerInterval default to 4ms, for use by all ports | ||
---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> |
Component: | WebKit Misc. | Assignee: | Matthew Delaney <mdelaney7> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | ap, cdumez, jamesr, jberlin, sfalken, srikumar.b |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Matthew Delaney
My understanding is that all ports either are currently manually setting the default to 4ms, or would like to be. Thus, we should just make the global default to be 4ms and then those who would like to opt-out of such high frequency timers can manually set the min interval to be larger. There also appears to be a lot of code that could be refactored/cleaned-up here. This bug should address all of this.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
*** Bug 67501 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
It doesn't seem like other ports chose to make this change. Not sure if that's intentional, or they just didn't get to it yet.
Srikumar B
Alexey,
The w3 standard says that the minimum should be 4ms right...Could you tell me which ports are not defining the minimal interval? I will try to make the changes for those ports.
(In reply to comment #2)
> It doesn't seem like other ports chose to make this change. Not sure if that's intentional, or they just didn't get to it yet.
Alexey Proskuryakov
You van grep the sources for ports that don't call setDefaultMinTimerInterval.
Chris Dumez
Will be closed by https://bugs.webkit.org/show_bug.cgi?id=142837.
Chris Dumez
Marking this bug as a duplicate even though it is older, as I already uploaded the patch to the other bug report.
*** This bug has been marked as a duplicate of bug 142837 ***