Bug 61202

Summary: [Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
Product: WebKit Reporter: Idrees <sidreesshah>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: ademar, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Test case
Patch for the fix. none

Description Idrees 2011-05-20 11:20:29 PDT
fast/canvas/webgl/gl-object-get-calls.html crashes for on qt webkit.

It seems like a unintentional left out from the code.
Comment 1 Idrees 2011-05-20 11:21:17 PDT
Created attachment 94245 [details]
Test case
Comment 2 Idrees 2011-05-20 11:33:07 PDT
Created attachment 94249 [details]
Patch for the fix.

getAttachedShaders should be called on GraphicsContext3DInternal instance. I think it was left by mistake. I have added it.
Comment 3 Andreas Kling 2011-05-22 23:00:20 PDT
Comment on attachment 94249 [details]
Patch for the fix.

Infinite recursion eh? Nice catch. r=me
Comment 4 WebKit Commit Bot 2011-05-23 01:07:15 PDT
Comment on attachment 94249 [details]
Patch for the fix.

Clearing flags on attachment: 94249

Committed r87059: <http://trac.webkit.org/changeset/87059>
Comment 5 WebKit Commit Bot 2011-05-23 01:07:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2011-05-27 11:36:06 PDT
Revision r87059 cherry-picked into qtwebkit-2.2 with commit d14495f <http://gitorious.org/webkit/qtwebkit/commit/d14495f>