Summary: | Web Inspector: [Chromium] Searching in a bottom-up view of a large CPU profile overloads system and finally stops execution of any Inspector code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://v8.googlecode.com/svn/data/benchmarks/current/run.html | ||||||
Attachments: |
|
Description
Mikhail Naganov
2011-05-20 05:34:19 PDT
Created attachment 94204 [details]
patch
Comment on attachment 94204 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=94204&action=review > Source/WebCore/bindings/js/ScriptProfile.cpp:71 > + // FIXME: implement building bottom-up profiles in C++ code, Please file a bug against JSC and put its number next to the FIXME. Manually committed: http://trac.webkit.org/changeset/86947 2011-05-20 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM, instead of building it on Inspector's side. https://bugs.webkit.org/show_bug.cgi?id=61185 * bindings/js/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead): * bindings/js/ScriptProfile.h: * bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead): * bindings/v8/ScriptProfile.h: * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getProfile): * inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree): (In reply to comment #2) > (From update of attachment 94204 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94204&action=review > > > Source/WebCore/bindings/js/ScriptProfile.cpp:71 > > + // FIXME: implement building bottom-up profiles in C++ code, > > Please file a bug against JSC and put its number next to the FIXME. Oh, sorry, I've already had an issue created: https://bugs.webkit.org/show_bug.cgi?id=61184 But I forgot to put it into fixme. |