| Summary: | Zombies should "live" forever | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Herczeg <zherczeg> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zoltan Herczeg
2011-05-20 00:07:58 PDT
Created attachment 94180 [details]
patch
Comment on attachment 94180 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=94180&action=review > Source/JavaScriptCore/JavaScriptCore.pro:-67 > - assembler/MacroAssemblerSH4.h \ > assembler/MacroAssemblerSH4.cpp \ > - assembler/SH4Assembler.h \ Why remove these? Or at least why remove them in this patch? > Source/JavaScriptCore/runtime/JSCell.h:362 > - return isCell() && asCell() > (JSCell*)0x1ffffffffL && asCell()->isZombie(); > + return isCell() && asCell()->isZombie(); whoops, i shouldn't have left this in, my bad. > Source/JavaScriptCore/runtime/WriteBarrier.h:132 > - ASSERT(!m_cell || !isZombie(m_cell)); > + ASSERT(!m_cell || value == reinterpret_cast<T*>(1) || !isZombie(m_cell)); What are you testing here? > > Source/JavaScriptCore/JavaScriptCore.pro:-67 > > - assembler/MacroAssemblerSH4.h \ > > assembler/MacroAssemblerSH4.cpp \ > > - assembler/SH4Assembler.h \ > > Why remove these? Or at least why remove them in this patch? True, it is unrelated. That list should contain only .cpp files. It is just a typo. > > Source/JavaScriptCore/runtime/WriteBarrier.h:132 > > - ASSERT(!m_cell || !isZombie(m_cell)); > > + ASSERT(!m_cell || value == reinterpret_cast<T*>(1) || !isZombie(m_cell)); > > What are you testing here? CodeBlock.h : setSeen(): cachedPrototypeStructure.setWithoutWriteBarrier((Structure*)1); Comment on attachment 94180 [details] patch Clearing flags on attachment: 94180 Committed r86974: <http://trac.webkit.org/changeset/86974> All reviewed patches have been landed. Closing bug. |