Bug 61153 – WebView loses firstResponder status when entering full-screen mode.

• Component: DOM
• Status: RESOLVED FIXED

[Andy Estes]

Space button does not play/pause video on apple.com when in full-screen mode.

[Andy Estes]

<rdar://problem/9400346>

[Andy Estes]

Created attachment 94145 [details]
Patch

[Darin Adler]

Comment on attachment 94145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review

> Source/WebKit/mac/Misc/WebNSWindowExtras.m:55
> +    if ([responder respondsToSelector:@selector(isDescendantOf:)]
> +        && [(id)responder isDescendantOf:view])

Should keep this expression all on one line to avoid awkward placement of the (id).

I suggest checking isKindOfClass:[NSView class] instead of specifically checking for this selector.

I don’t think it’s really so convenient to have this as an NSWindow method. I would suggest just making a helper function that does this. But I guess you made it a method so you could share with WebKit2. I am not really sure that’s the best practice way to make code you can share with WebKit1 and WebKit2. Might be worth asking Sam about that.

[Andy Estes]

(In reply to comment #3)
> (From update of attachment 94145 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review
> 
> > Source/WebKit/mac/Misc/WebNSWindowExtras.m:55
> > +    if ([responder respondsToSelector:@selector(isDescendantOf:)]
> > +        && [(id)responder isDescendantOf:view])
> 
> Should keep this expression all on one line to avoid awkward placement of the (id).
> 
> I suggest checking isKindOfClass:[NSView class] instead of specifically checking for this selector.
> 
> I don’t think it’s really so convenient to have this as an NSWindow method. I would suggest just making a helper function that does this. But I guess you made it a method so you could share with WebKit2. I am not really sure that’s the best practice way to make code you can share with WebKit1 and WebKit2. Might be worth asking Sam about that.

Thanks Darin. I'll ping Sam for suggestions.

[Andy Estes]

Committed r86995: <http://trac.webkit.org/changeset/86995>

[Andy Estes]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 94145 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review
> > 
> > > Source/WebKit/mac/Misc/WebNSWindowExtras.m:55
> > > +    if ([responder respondsToSelector:@selector(isDescendantOf:)]
> > > +        && [(id)responder isDescendantOf:view])
> > 
> > Should keep this expression all on one line to avoid awkward placement of the (id).
> > 
> > I suggest checking isKindOfClass:[NSView class] instead of specifically checking for this selector.
> > 
> > I don’t think it’s really so convenient to have this as an NSWindow method. I would suggest just making a helper function that does this. But I guess you made it a method so you could share with WebKit2. I am not really sure that’s the best practice way to make code you can share with WebKit1 and WebKit2. Might be worth asking Sam about that.
> 
> Thanks Darin. I'll ping Sam for suggestions.

Sam suggested I add the helper function to WebCore. I'll do that in a follow-up patch.