Summary: | MessagePortArray cloning code needs to verify source before copying | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> | ||||||
Component: | WebCore JavaScript | Assignee: | Andrew Wilson <atwilson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ademar, commit-queue, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andrew Wilson
2011-05-19 10:14:13 PDT
Created attachment 94086 [details]
Patch to change the MessagePortArray copying code to not pre-allocate the destination.
Note that this new code (not pre-allocating the destination) is just as fast as the old code for any arrays containing up to 16 MessagePorts (which covers all expected use cases in practice).
Attachment 94086 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5]
Total errors found: 3 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 94086 [details]
Patch to change the MessagePortArray copying code to not pre-allocate the destination.
Change looks fine, but tabs in change log will cause the commit queue to fail.
Created attachment 94097 [details]
Patch without tabs in ChangeLog
Comment on attachment 94097 [details]
Patch without tabs in ChangeLog
I removed those tabs, but the patch is otherwise identical. Anyone want to re-r+ this so the commit-queue can take it?
Comment on attachment 94097 [details]
Patch without tabs in ChangeLog
Next time I think you should set commit-queue to ? rather than to +. Unless I am ignorant about how commit-queue+ works.
You're probably right - it's been a while since I've landed anything but test_expectations changes so I'm a bit rusty on the process :( I should probably also wait on the EWS bots before R? it too. Thanks for the quick turnaround on the reviews! Comment on attachment 94097 [details] Patch without tabs in ChangeLog Clearing flags on attachment: 94097 Committed r86899: <http://trac.webkit.org/changeset/86899> All reviewed patches have been landed. Closing bug. Revision r86899 cherry-picked into qtwebkit-2.2 with commit 63adcb6 <http://gitorious.org/webkit/qtwebkit/commit/63adcb6> |