Bug 6112 – REGRESSION: navigator.plugins empty

• Component: JavaScriptCore
• Status: VERIFIED FIXED

navigator.plugins returns an empty PluginArray. At the same time, the following error is printed:

ERROR: config number not implemented
(.../WebCore/kwq/KWQKConfigBase.mm:123 readNumEntry)

One way to reproduce is to choose Help > Installed Plug-ins in Safari.

This is a very fresh regression.

The regression is due to this change in kjs_navigator.cpp r1.41:

-        KConfig c(KGlobal::dirs()->saveLocation("data","nsplugins")+"/pluginsinfo");
+        KConfig c("");

I should add that the simplest fix is to pass "pluginsinfo" to the constructor.

[Geoffrey Garen]

Created attachment 5115 [details]
Fix

Mitz is right. Eric thought the old code passed a single string to a
constructor that returned NULL, so he replaced that string with "". In fact,
the old code passed one string to a constructor that returned NULL, and then
concatenated "pluginsinfo" to that string. So "pluginsinfo" is what we want.

[Geoffrey Garen]

I'm going to add "Plug-ins.html" to our layout test suite when I land this.

[Geoffrey Garen]

Created attachment 5116 [details]
Fix

Previous patch had extra junk in it.

[Eric Seidel (no email)]

Comment on attachment 5116 [details]
Fix

Agreed.  Mitz and I were discussting making this an enum, etc. but that can be
done later (in my next cleanup patch!).  Thanks for fixing this.  r=me

[Eric Seidel (no email)]

Oh, as a side-note.  Plugins.html (your test) should check that navigator.plugins has above a certain 
number of plugins, or perhaps one or two which we ship by default.  Unfortunately it can't just dump all 
the plugins as those will be different between machines.  Thanks again.

Thanks, Geoffrey!