Bug 61074

Summary: Teach Qt about window.internals
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: Tools / TestsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, dominicc, kling, laszlo.gombos, luiz, robert, tonikitoo, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 60313    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+

Description WebKit Review Bot 2011-05-18 10:07:19 PDT
Teach Qt about window.internals
Requested by dglazkov on #webkit.
Comment 1 Robert Hogan 2011-06-08 12:17:43 PDT
Created attachment 96458 [details]
Patch
Comment 2 Robert Hogan 2011-06-08 12:21:28 PDT
Maybe I'm missing a trick here, but I can't see a way of making WebCoreTestSupport work as a separate library in Qt. This is principally because JSContextRef and co. are not available at the API level.
Comment 3 Dimitri Glazkov (Google) 2011-06-08 12:43:45 PDT
(In reply to comment #2)
> Maybe I'm missing a trick here, but I can't see a way of making WebCoreTestSupport work as a separate library in Qt. This is principally because JSContextRef and co. are not available at the API level.

Ah interesting. I didn't realize this.

Love the code though! Can Qt folks look over and r+?
Comment 4 Andreas Kling 2011-06-08 12:48:49 PDT
Comment on attachment 96458 [details]
Patch

Approve patches (Like a boss!)
Comment 5 Dominic Cooney 2011-06-09 07:07:54 PDT
Committed r88446.