Bug 61074

Summary:

Teach Qt about window.internals

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

Tools / Tests

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, dominicc, kling, laszlo.gombos, luiz, robert, tonikitoo, yael

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

60313

Bug Blocks:

Attachments:

Description	Flags
Patch	kling: review+

WebKit Review Bot

Reported 2011-05-18 10:07:19 PDT

Teach Qt about window.internals Requested by dglazkov on #webkit.

Attachments
Patch (10.23 KB, patch) 2011-06-08 12:17 PDT, Robert Hogan	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Robert Hogan

Comment 1 2011-06-08 12:17:43 PDT

Created attachment 96458 [details] Patch

Robert Hogan

Comment 2 2011-06-08 12:21:28 PDT

Maybe I'm missing a trick here, but I can't see a way of making WebCoreTestSupport work as a separate library in Qt. This is principally because JSContextRef and co. are not available at the API level.

Dimitri Glazkov (Google)

Comment 3 2011-06-08 12:43:45 PDT

(In reply to comment #2) > Maybe I'm missing a trick here, but I can't see a way of making WebCoreTestSupport work as a separate library in Qt. This is principally because JSContextRef and co. are not available at the API level. Ah interesting. I didn't realize this. Love the code though! Can Qt folks look over and r+?

Andreas Kling

Comment 4 2011-06-08 12:48:49 PDT

Comment on attachment 96458 [details] Patch Approve patches (Like a boss!)

Dominic Cooney

Comment 5 2011-06-09 07:07:54 PDT

Committed r88446.

Note You need to log in before you can comment on or make changes to this bug.