Bug 6107

Summary: Decoder should use Shared<T> and clients should use RefPtr<Decoder>
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: WebKit Misc.Assignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Proposed patch. darin: review+

Eric Seidel (no email)
Reported 2005-12-16 02:04:56 PST
Decoder should use Shared<T> and clients should use RefPtr<Decoder> Patch attached.
Attachments
Proposed patch. (8.53 KB, patch)
2005-12-16 02:13 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-12-16 02:13:51 PST
Created attachment 5107 [details] Proposed patch.
Darin Adler
Comment 2 2005-12-16 07:11:08 PST
Comment on attachment 5107 [details] Proposed patch. Looks fine, although I don't think ~DocumentImpl needs to explicitly set m_decoder to 0 any more. r=me
Darin Adler
Comment 3 2005-12-18 14:19:48 PST
The changes from bug 6107 introduce one more cases where Decoder is used, which will need to be revised to be compatible with this fix.
Eric Seidel (no email)
Comment 4 2005-12-18 14:25:20 PST
Will do.
Eric Seidel (no email)
Comment 5 2005-12-20 01:04:47 PST
Fixed.
Note You need to log in before you can comment on or make changes to this bug.