Summary: | TestFailures page should provide links to regression ranges in Trac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar, ToolsHitList | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://build.webkit.org/TestFailures/ | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-05-18 08:45:02 PDT
Created attachment 98519 [details]
Add links to regression ranges in Trac to the TestFailures page
Comment on attachment 98519 [details] Add links to regression ranges in Trac to the TestFailures page View in context: https://bugs.webkit.org/attachment.cgi?id=98519&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:32 > + return addQueryParametersToURL(this.baseURL + 'log/' + path, { rev: endRevision, stop_rev: startRevision }); Kind of funny that stop_rev == startRevision, but maybe trac's terminology is backwards? Comment on attachment 98519 [details] Add links to regression ranges in Trac to the TestFailures page View in context: https://bugs.webkit.org/attachment.cgi?id=98519&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:32 >> + return addQueryParametersToURL(this.baseURL + 'log/' + path, { rev: endRevision, stop_rev: startRevision }); > > Kind of funny that stop_rev == startRevision, but maybe trac's terminology is backwards? log is a backward-looking UI, so it starts at a particular revision and goes backward in time from there. Committed r89695: <http://trac.webkit.org/changeset/89695> |