Summary: | Most built-in properties are not deletable | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, arv, barraclough, erights, erikcorry, rniwa, webkit.review.bot, webmaster | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 66473 | ||||||
Attachments: |
|
Description
Geoffrey Garen
2011-05-17 18:50:31 PDT
See also: bug 55034 (global object's Math property should be deletable) Created attachment 111100 [details]
The patch
Attachment 111100 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/runtime/JSObject.h:77: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/JSObject.h:77: The parameter name "entry" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/JSObject.h:77: The parameter name "slot" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/JSObject.h:214: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 4 in 65 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 111100 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=111100&action=review > Source/JavaScriptCore/runtime/JSObject.h:214 > + void reifyStaticFunctions(ExecState* exec); Rename to reifyStaticFunctionsForDelete(). > Source/JavaScriptCore/runtime/Structure.h:296 > + // 7 free bits Maybe delete this comment? It's probably wrong and unlikely to be useful. The problem for static functions is fixed in r97536. A couple of custom getters might still have an issue, we should look into this. Comment on attachment 111100 [details]
The patch
clearing review flag on landed patch.
It seems like this patch broke Windows build: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/40962/steps/compile-webkit/logs/stdio This looks like a dupe of https://bugs.webkit.org/show_bug.cgi?id=25527 Attempted to fix the Windows build in http://trac.webkit.org/changeset/97610 …and r97615 …and r97620 At https://bugs.webkit.org/show_bug.cgi?id=70207#c2 Gavin confirms this issue is related to that one. No sure why I didn't close this; not aware of any other specific issues, if any other properties that should be deletable are not, that should warrant separate bug reports. Fixed in r97536. *** Bug 66473 has been marked as a duplicate of this bug. *** |