Bug 60992

Summary: [Qt] Fix plugins/windowless_plugin_paint_test.html
Product: WebKit Reporter: Robert Hogan <robert>
Component: New BugsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Robert Hogan
Reported 2011-05-17 14:48:26 PDT
[Qt] Fix plugins/windowless_plugin_paint_test.html
Attachments
Patch (3.07 KB, patch)
2011-05-17 14:51 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Patch (5.04 KB, patch)
2011-05-18 11:58 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2011-05-17 14:51:13 PDT
Created attachment 93820 [details] Patch
WebKit Review Bot
Comment 2 2011-05-17 14:54:14 PDT
Attachment 93820 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebCore/plugins/qt/PluginViewQt.cpp:858: gdk_init_check is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2011-05-17 17:08:25 PDT
Comment on attachment 93820 [details] Patch We're gonna need the same snippet in Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapeluginX11.cpp
Robert Hogan
Comment 4 2011-05-18 11:58:12 PDT
Created attachment 93959 [details] Patch
Andreas Kling
Comment 5 2011-05-18 11:59:35 PDT
Comment on attachment 93959 [details] Patch Kool. rs=me
WebKit Review Bot
Comment 6 2011-05-18 12:01:26 PDT
Attachment 93959 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/plugins/qt/PluginViewQt.cpp:858: gdk_init_check is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2011-05-19 11:59:43 PDT
Comment on attachment 93959 [details] Patch Clearing flags on attachment: 93959 Committed r86870: <http://trac.webkit.org/changeset/86870>
WebKit Commit Bot
Comment 8 2011-05-19 11:59:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.