Bug 60977

Summary:

[chromium] Always set layerRenderer, even on non-drawn-layers

Product:

WebKit

Reporter:

Nat Duca <nduca>

Component:

New Bugs

Assignee:

Nat Duca <nduca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jamesr, nduca

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Add some comments for posterity.	none

Nat Duca

Reported 2011-05-17 12:12:08 PDT

[chromium] Always set layerRenderer, even on non-drawn-layers

Attachments
Patch (2.68 KB, patch) 2011-05-17 12:16 PDT, Nat Duca	no flags	Details Formatted Diff Diff
Add some comments for posterity. (3.30 KB, patch) 2011-05-17 13:00 PDT, Nat Duca	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Nat Duca

Comment 1 2011-05-17 12:16:28 PDT

James Robinson

Comment 2 2011-05-17 12:38:54 PDT

Comment on attachment 93805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93805&action=review Change looks good. Is there any way to test this (even manually)? > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:353 > + renderSurfaceLayer->setLayerRenderer(this); I think this is redundant - have you checked if this helps? drawLayers() skips render surfaces with an empty layer list (see http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp#L448). I suppose it doesn't hurt to set it regardless.

Nat Duca

Comment 3 2011-05-17 13:00:52 PDT

Created attachment 93810 [details] Add some comments for posterity.

WebKit Commit Bot

Comment 4 2011-05-17 15:34:33 PDT

Comment on attachment 93810 [details] Add some comments for posterity. Clearing flags on attachment: 93810 Committed r86713: <http://trac.webkit.org/changeset/86713>

WebKit Commit Bot

Comment 5 2011-05-17 15:34:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.