Bug 60940 (TimeBomb)
| Summary: | [Qt] QWebHistoryItem.lastVisited() returns an invalid, non-relevant date | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | usaman2010us |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Major | CC: | andersca, benjamin, jedrzej.nowacki, kling, robert |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 525.x (Safari 3.2) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
usaman2010us
When grabbing QWebHistory from QWebView, and then grabbing any item[s] from the QWebHistory, the title() and url() methods work fine, but the lastVisited() method returns QDateTime("Wed Dec 31 16:00:00 1969") every single time, despite being valid (tested via isValid()).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Benjamin Poulain
Would you mind attaching a test case?
Which version of Qt/WebKit do you use?
Andreas Kling
Suspicious comment from QWebHistoryItem::lastVisited():
//FIXME : this will be wrong unless we correctly set lastVisitedTime ourselves
Robert Hogan
(In reply to comment #2)
> Suspicious comment from QWebHistoryItem::lastVisited():
>
> //FIXME : this will be wrong unless we correctly set lastVisitedTime ourselves
Should this fixed or deprecated? It seems like dispatchDidAddBackForwardItem() would be the place to set it if we want to fix it. Other ports expose it to the client, and let them set it.
No other port has anything at all in dispatchDidAddBackForwardItem()!