Summary: | editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ademar, darin, enrica, morrita, ojan, tkent, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60914 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-05-16 13:50:34 PDT
Created attachment 93690 [details]
converted the test
Comment on attachment 93690 [details] converted the test View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review I would prefer if you renamed the file instead of removing and adding, simply to preserve the change history. > LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6 > <script> Since you're rewriting this, I would add the instructions to run the test manually, just for the sake of clarity. Thanks for the review! (In reply to comment #2) > (From update of attachment 93690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review > > I would prefer if you renamed the file instead of removing and adding, simply to preserve the change history. Yes, I did use svn mv. It's just that pretty-patch doesn't support it. > > LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6 > > <script> > > Since you're rewriting this, I would add the instructions to run the test manually, just for the sake of clarity. Will do! Committed r86605: <http://trac.webkit.org/changeset/86605> Revision r86605 cherry-picked into qtwebkit-2.2 with commit b3dc19e <http://gitorious.org/webkit/qtwebkit/commit/b3dc19e> Revision r86605 cherry-picked into qtwebkit-2.2 with commit 40d8b0f <http://gitorious.org/webkit/qtwebkit/commit/40d8b0f> |