Bug 60920 – editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test

• Component: HTML Editing
• Status: RESOLVED FIXED

[Ryosuke Niwa]

5091898.html should be a dump-as-markup test and the filename should be changed to something more descriptive.

[Ryosuke Niwa]

Created attachment 93690 [details]
converted the test

[Enrica Casucci]

Comment on attachment 93690 [details]
converted the test

View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review

I would prefer if you renamed the file instead of removing and adding, simply to preserve the change history.

> LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6
>  <script>

Since you're rewriting this, I would add the instructions to run the test manually, just for the sake of clarity.

[Ryosuke Niwa]

Thanks for the review!

(In reply to comment #2)
> (From update of attachment 93690 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93690&action=review
> 
> I would prefer if you renamed the file instead of removing and adding, simply to preserve the change history.

Yes, I did use svn mv.  It's just that pretty-patch doesn't support it.

> > LayoutTests/editing/deleting/delete-line-break-before-underlined-content.html:6
> >  <script>
> 
> Since you're rewriting this, I would add the instructions to run the test manually, just for the sake of clarity.

Will do!

[Ryosuke Niwa]

Committed r86605: <http://trac.webkit.org/changeset/86605>

[Ademar Reis]

Revision r86605 cherry-picked into qtwebkit-2.2 with commit b3dc19e <http://gitorious.org/webkit/qtwebkit/commit/b3dc19e>

[Ademar Reis]

Revision r86605 cherry-picked into qtwebkit-2.2 with commit 40d8b0f <http://gitorious.org/webkit/qtwebkit/commit/40d8b0f>