Bug 60901

Summary: [Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 61001    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch kenneth: review+

Andreas Kling
Reported 2011-05-16 10:04:40 PDT
To prepare for the eventual removal of the ChunkedUpdateDrawingArea, make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.
Attachments
Proposed patch (2.85 KB, patch)
2011-05-16 10:05 PDT, Andreas Kling 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-05-16 10:05:09 PDT
Created attachment 93658 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-05-16 10:06:54 PDT
Attachment 93658 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2011-05-16 10:15:06 PDT
(In reply to comment #2) > Attachment 93658 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 > > Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 1 in 3 files Derp! Will include the bug# when landing. :)
Kenneth Rohde Christiansen
Comment 4 2011-05-16 12:04:05 PDT
Comment on attachment 93658 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=93658&action=review > Source/WebKit2/ChangeLog:5 > + [Qt][WK2] Remove usage of ChunkedUpdateDrawingArea. Where is the bug id?
Andreas Kling
Comment 5 2011-05-17 04:41:48 PDT
Committed r86668: <http://trac.webkit.org/changeset/86668>
Csaba Osztrogonác
Comment 6 2011-05-17 22:35:08 PDT
Rolled out: http://trac.webkit.org/changeset/86719
Andreas Kling
Comment 7 2011-05-18 08:50:04 PDT
Committed r86767: <http://trac.webkit.org/changeset/86767>
Note You need to log in before you can comment on or make changes to this bug.