Bug 6090

Summary:

REGRESSION: Assertion failure when choosing Copy from a WebImageView's contextual menu

Product:

WebKit

Reporter:

mitz

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

VERIFIED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Use the correct key for the image renderer	darin: review-
Updated patch	darin: review+

mitz

Reported 2005-12-14 22:39:17 PST

Summary: the following assert fails when you choose Copy from the contextual menu of a WebImageView: image (WebKit/WebKit/Misc.subproj/WebNSPasteboardExtras.m:229 -[NSPasteboard(WebExtras) _web_writeImage:URL:title:archive:types:]) To reproduce: open an image file in its own Safari window, control-click the image and choose copy. With a deployment build, you can verify that the image wasn't copied to the clipboard. This is similar to bug 6032 and I have a patch.

Attachments
Use the correct key for the image renderer (1.83 KB, patch) 2005-12-14 22:56 PST, mitz	darin: review-	Details Formatted Diff Diff
Updated patch (1.91 KB, patch) 2005-12-15 08:53 PST, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2005-12-14 22:56:08 PST

Created attachment 5082 [details] Use the correct key for the image renderer

Darin Adler

Comment 2 2005-12-15 06:30:31 PST

Comment on attachment 5082 [details] Use the correct key for the image renderer r=me

Darin Adler

Comment 3 2005-12-15 06:32:10 PST

Comment on attachment 5082 [details] Use the correct key for the image renderer Dictionary needs to include both the image renderer (for use inside WebKit) and the image (for use by other callers), so we need to add WebElementImageKey with the image as well.

mitz

Comment 4 2005-12-15 08:53:28 PST

Created attachment 5094 [details] Updated patch

Darin Adler

Comment 5 2005-12-16 00:05:53 PST

Comment on attachment 5094 [details] Updated patch r=me

Note You need to log in before you can comment on or make changes to this bug.