Initial LocalizedDateICU.cpp implementation

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

LocalizedDateICU.cpp implementation.  Just for type=date.

[Kent Tamura]

Created attachment 93602 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 93602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93602&action=review

Nice! This looks good to me. I'll let a Chromium reviewer r+ since this affects the Chromium port.

> LayoutTests/fast/forms/date-input-visible-strings.html:35
> +    debug(input.type + ": value='" + input.value + "' visible='" + document.getSelection().toString() + "'");

Clever solution to making this a dump as text test. I like it!

> Source/WebCore/ChangeLog:12
> +        * WebCore.gypi: Add LocalizedDateICu.cpp.

Nit (typo): "ICu.cpp" => "ICU.cpp"

> Source/WebCore/platform/text/LocalizedDateICU.cpp:35
> +#include <unicode/datefmt.h> // smpdtfmt.h?

I don't understand this comment. Should it be removed?

[WebKit Review Bot]

Comment on attachment 93602 [details]
Patch

Attachment 93602 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8695881

New failing tests:
fast/forms/date-input-visible-strings.html

[WebKit Review Bot]

Created attachment 93607 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Kent Tamura]

Created attachment 93608 [details]
Patch 2

[Kent Tamura]

Comment on attachment 93602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93602&action=review

>> Source/WebCore/ChangeLog:12
>> +        * WebCore.gypi: Add LocalizedDateICu.cpp.
> 
> Nit (typo): "ICu.cpp" => "ICU.cpp"

Fixed.

>> Source/WebCore/platform/text/LocalizedDateICU.cpp:35
>> +#include <unicode/datefmt.h> // smpdtfmt.h?
> 
> I don't understand this comment. Should it be removed?

Oops, it doesn't make sense.  I removed.

[Darin Adler]

Comment on attachment 93608 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=93608&action=review

> Source/WebCore/platform/text/LocalizedDateICU.cpp:35
> +#include <unicode/datefmt.h>

We normally use the C interface to ICU rather than the C++ interface. This is more compatible across versions of ICU. Could you do the same here? I presume the same capabilities exist in the C version.

[Alexey Proskuryakov]

Where does the format come from? Will this test be always failing for me in DRT, because the primary language of my Mac OS X installation is not English?

[Kent Tamura]

(In reply to comment #8)
> Where does the format come from? Will this test be always failing for me in DRT, because the primary language of my Mac OS X installation is not English?

Good point.
The format should come from user's OS settings.
In Chromium project we assume DRT runs on en_US systems.  So platform/chromium/fast/forms/date-input-visible-strings-expected.txt in this patch is acceptable.  But I don't know other ports have such assumptions.

We should have MockLocalizedDate.cpp and use it in DRT?

[Kent Tamura]

Created attachment 135988 [details]
Patch 3

Uses ICU C API

[WebKit Review Bot]

Comment on attachment 135988 [details]
Patch 3

Clearing flags on attachment: 135988

Committed r113422: <http://trac.webkit.org/changeset/113422>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.