Bug 60805

Summary: Enable -Wnewline-eof on ANGLE
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebGLAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1
webkit.review.bot: commit-queue-
Patch v2 aroben: review+

David Kilzer (:ddkilzer)
Reported 2011-05-13 14:34:32 PDT
ANGLE should compile with -Wnewline-eof just like all the other projects. Blocked on upstream: <http://code.google.com/p/angleproject/issues/detail?id=154>
Attachments
Patch v1 (1.28 KB, patch)
2011-05-13 14:38 PDT, David Kilzer (:ddkilzer) 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (1.36 KB, patch)
2011-05-23 17:00 PDT, David Kilzer (:ddkilzer) 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2011-05-13 14:38:36 PDT
Created attachment 93514 [details] Patch v1
WebKit Review Bot
Comment 2 2011-05-13 15:16:20 PDT
Comment on attachment 93514 [details] Patch v1 Attachment 93514 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8698193
David Kilzer (:ddkilzer)
Comment 3 2011-05-23 16:54:47 PDT
Part 1 of 2: Committed r87108: <http://trac.webkit.org/changeset/87108>
David Kilzer (:ddkilzer)
Comment 4 2011-05-23 17:00:04 PDT
Created attachment 94520 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 5 2011-05-24 08:12:11 PDT
Part 2 of 2: Committed r87149: <http://trac.webkit.org/changeset/87149>
Note You need to log in before you can comment on or make changes to this bug.