Bug 60805

Summary:

Enable -Wnewline-eof on ANGLE

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebGL

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	webkit.review.bot: commit-queue-
Patch v2	aroben: review+

Description David Kilzer (:ddkilzer) 2011-05-13 14:34:32 PDT

ANGLE should compile with -Wnewline-eof just like all the other projects.

Blocked on upstream:  <http://code.google.com/p/angleproject/issues/detail?id=154>

Comment 1 David Kilzer (:ddkilzer) 2011-05-13 14:38:36 PDT

Created attachment 93514 [details]
Patch v1

Comment 2 WebKit Review Bot 2011-05-13 15:16:20 PDT

Comment on attachment 93514 [details]
Patch v1

Attachment 93514 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8698193

Comment 3 David Kilzer (:ddkilzer) 2011-05-23 16:54:47 PDT

Part 1 of 2:

Committed r87108: <http://trac.webkit.org/changeset/87108>

Comment 4 David Kilzer (:ddkilzer) 2011-05-23 17:00:04 PDT

Created attachment 94520 [details]
Patch v2

Comment 5 David Kilzer (:ddkilzer) 2011-05-24 08:12:11 PDT

Part 2 of 2:

Committed r87149: <http://trac.webkit.org/changeset/87149>