Bug 60798

Summary: WebURLResponse should not make NULL File objects
Product: WebKit Reporter: Brett Wilson (Google) <brettw>
Component: WebKit APIAssignee: Brett Wilson (Google) <brettw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, darin, michaeln, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch (style fixed) none

Brett Wilson (Google)
Reported 2011-05-13 13:42:45 PDT
My fix for bug 60281 created File objects for download files. This is almost never necessary, and has some IPC overhead. Even if Chromium removed the unnecessary IPC for empty file objects, the allocation is still a waste of time.
Attachments
Patch (1.24 KB, patch)
2011-05-13 13:46 PDT, Brett Wilson (Google) 		no flags
DetailsFormatted DiffDiff
Patch (style fixed) (1.24 KB, patch)
2011-05-13 16:13 PDT, Brett Wilson (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brett Wilson (Google)
Comment 1 2011-05-13 13:46:58 PDT
Created attachment 93503 [details] Patch
WebKit Review Bot
Comment 2 2011-05-13 13:49:07 PDT
Attachment 93503 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebURLResponse.cpp:376: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brett Wilson (Google)
Comment 3 2011-05-13 16:13:55 PDT
Created attachment 93527 [details] Patch (style fixed)
Michael Nordman
Comment 4 2011-05-13 18:17:03 PDT
lgtm... thnx!
Michael Nordman
Comment 5 2011-05-16 19:46:33 PDT
i'm surprised the bug tracker let me flip that bit
Adam Barth
Comment 6 2011-05-18 13:08:58 PDT
Comment on attachment 93527 [details] Patch (style fixed) It's too bad we can't test changes like this. They're easy to regress.
WebKit Commit Bot
Comment 7 2011-05-18 15:17:24 PDT
Comment on attachment 93527 [details] Patch (style fixed) Clearing flags on attachment: 93527 Committed r86799: <http://trac.webkit.org/changeset/86799>
WebKit Commit Bot
Comment 8 2011-05-18 15:17:29 PDT
All reviewed patches have been landed. Closing bug.
Michael Nordman
Comment 9 2011-05-18 17:32:40 PDT
Seems like there could be a unit test for this setter... WebKit\Source\WebKit\chromium\tests
Note You need to log in before you can comment on or make changes to this bug.