Bug 60776

Summary: It's hard to write tests that check plugin window geometry
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60194    
Attachments:
Description Flags
Move code required for most tests of plugin window geometry into a base class
none
Move code required for most tests of plugin window geometry into a base class andersca: review+

Description Adam Roben (:aroben) 2011-05-13 09:16:24 PDT
It's hard to write tests that check plugin window geometry
Comment 1 Adam Roben (:aroben) 2011-05-13 09:18:37 PDT
Created attachment 93462 [details]
Move code required for most tests of plugin window geometry into a base class
Comment 2 Adam Roben (:aroben) 2011-05-13 09:20:41 PDT
Created attachment 93463 [details]
Move code required for most tests of plugin window geometry into a base class
Comment 3 WebKit Review Bot 2011-05-13 09:22:23 PDT
Attachment 93462 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2011-05-13 10:25:48 PDT
Committed r86441: <http://trac.webkit.org/changeset/86441>