Bug 60776

Summary: It's hard to write tests that check plugin window geometry
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60194    
Attachments:
Description Flags
Move code required for most tests of plugin window geometry into a base class
none
Move code required for most tests of plugin window geometry into a base class andersca: review+

Adam Roben (:aroben)
Reported 2011-05-13 09:16:24 PDT
It's hard to write tests that check plugin window geometry
Attachments
Move code required for most tests of plugin window geometry into a base class (16.00 KB, patch)
2011-05-13 09:18 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Move code required for most tests of plugin window geometry into a base class (20.67 KB, patch)
2011-05-13 09:20 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-05-13 09:18:37 PDT
Created attachment 93462 [details] Move code required for most tests of plugin window geometry into a base class
Adam Roben (:aroben)
Comment 2 2011-05-13 09:20:41 PDT
Created attachment 93463 [details] Move code required for most tests of plugin window geometry into a base class
WebKit Review Bot
Comment 3 2011-05-13 09:22:23 PDT
Attachment 93462 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 4 2011-05-13 10:25:48 PDT
Committed r86441: <http://trac.webkit.org/changeset/86441>
Note You need to log in before you can comment on or make changes to this bug.