Bug 60737

Summary:

Inconsistent scroll position at RTL page edge

Product:

WebKit

Reporter:

Adrienne Walker <enne>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, leviw, robin.qiu.dev, webkit.review.bot, xji

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test case	none
Incorrect scroll screenshot	none
Another bug.	none
Qt porting has the same problem.	none
Not only RTL pages have this bug, all scrollable areas have this bug.	none
Draft patch	none
Patch v1	webkit.review.bot: commit-queue-
Patch v1, test again.	webkit.review.bot: commit-queue-
Patch v2	none

Description Adrienne Walker 2011-05-12 16:47:56 PDT

Created attachment 93367 [details]
Test case

I was loading the attached page on Chromium Linux (WebKit r86394) and noticed some scrolling oddities when scrolling all the way to the left.  In some cases, it appears as though the page doesn't scroll all the way that it should and cuts off some of the text.

If I mouse down and drag left, the page scrolls the rest of the way.  This happens intermittently but seems to happen more if I am scrolling slowly.

Comment 1 Adrienne Walker 2011-05-12 16:48:48 PDT

Created attachment 93368 [details]
Incorrect scroll screenshot

I'd expect to see ZYX all on screen unlike this screenshot.

Comment 2 Robin Qiu 2011-07-13 06:49:40 PDT

Created attachment 100669 [details]
Another bug. 

The content is painted in wrong place after resizing the window. (not 100% reproducible).

Comment 3 Robin Qiu 2011-07-13 06:57:47 PDT

Created attachment 100670 [details]
Qt porting has the same problem.

Comment 4 Robin Qiu 2011-07-18 06:17:29 PDT

Created attachment 101154 [details]
Not only RTL pages have this bug, all scrollable areas have this bug.

This test case shows how to 100% reproduce this scroll position bug.

Comment 5 Robin Qiu 2011-07-19 05:45:47 PDT

Created attachment 101305 [details]
Draft patch

Comment 6 Robin Qiu 2011-07-19 06:57:03 PDT

Created attachment 101313 [details]
Patch v1

The fix is simple. :)

Comment 7 WebKit Review Bot 2011-07-19 14:00:07 PDT

Comment on attachment 101313 [details]
Patch v1

Attachment 101313 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9168006

New failing tests:
fast/overflow/image-selection-highlight.html
fast/layers/scroll-rect-to-visible.html
fast/multicol/scrolling-overflow.html
fast/repaint/fixed-child-move-after-scroll.html
fast/dynamic/anchor-lock.html
fast/repaint/fixed-tranformed.html
fast/repaint/block-selection-gap-stale-cache-2.html
fast/repaint/fixed-child-of-fixed-move-after-scroll.html
fast/overflow/scrollbar-position-update.html
fast/dom/focus-contenteditable.html
fast/overflow/position-fixed-transform-clipping.html
fast/repaint/fixed-move-after-scroll.html
fast/overflow/008.html
fast/overflow/clip-rects-fixed-ancestor.html
fast/repaint/fixed-child-of-transformed-move-after-scroll.html
fast/overflow/scrollRevealButton.html
fast/dom/scroll-reveal-top-overflow.html
fast/dom/scroll-reveal-left-overflow.html

Comment 8 Robin Qiu 2011-07-20 02:08:09 PDT

Created attachment 101441 [details]
Patch v1, test again.

Comment 9 WebKit Review Bot 2011-07-20 03:26:38 PDT

Comment on attachment 101441 [details]
Patch v1, test again.

Attachment 101441 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9199227

New failing tests:
fast/overflow/image-selection-highlight.html
fast/forms/input-number-events.html
fast/multicol/scrolling-overflow.html
fast/dom/scroll-reveal-left-overflow.html
fast/forms/input-number-large-padding.html
fast/repaint/fixed-child-move-after-scroll.html
fast/dynamic/anchor-lock.html
fast/repaint/block-selection-gap-stale-cache-2.html
fast/repaint/fixed-child-of-fixed-move-after-scroll.html
fast/overflow/008.html
fast/overflow/scrollbar-position-update.html
fast/dom/focus-contenteditable.html
fast/overflow/position-fixed-transform-clipping.html
fast/repaint/fixed-move-after-scroll.html
fast/forms/input-spinbutton-capturing.html
fast/overflow/clip-rects-fixed-ancestor.html
fast/repaint/fixed-child-of-transformed-move-after-scroll.html
fast/overflow/scrollRevealButton.html
fast/dom/scroll-reveal-top-overflow.html
fast/layers/scroll-rect-to-visible.html

Comment 10 Robin Qiu 2011-07-20 06:32:39 PDT

Created attachment 101459 [details]
Patch v2

Comment 11 Antonio Gomes 2011-07-21 06:31:50 PDT

Comment on attachment 101459 [details]
Patch v2

Feel free to cq+ it when you can watch the bots.

Comment 12 Robin Qiu 2011-07-21 06:42:52 PDT

(In reply to comment #11)
> (From update of attachment 101459 [details])
> Feel free to cq+ it when you can watch the bots.
OK, thanks for your review. :)

Comment 13 WebKit Review Bot 2011-07-21 20:01:05 PDT

Comment on attachment 101459 [details]
Patch v2

Clearing flags on attachment: 101459

Committed r91547: <http://trac.webkit.org/changeset/91547>

Comment 14 WebKit Review Bot 2011-07-21 20:01:10 PDT

All reviewed patches have been landed.  Closing bug.