Bug 60669

Summary: After relaunching an unresponsive web process, web page stops responding to mouse movement
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: WebKit2Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aroben, darin, sam, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Fix with test
aroben: review-
[PATCH] Fix with faster test andersca: review+

Description Brian Weinstein 2011-05-11 15:36:55 PDT
After relaunching an unresponsive web process, web page stops responding to mouse movement 

You can't can't scroll by dragging scrollbar, can't select text, etc.

<rdar://problem/9409934>
Comment 1 Brian Weinstein 2011-05-11 17:35:07 PDT
Created attachment 93221 [details]
[PATCH] Fix with test
Comment 2 Brian Weinstein 2011-05-11 17:58:47 PDT
Sam stated this test will take too long. Waiting for the responsiveness callback is too long to wait for this test.
Comment 3 Adam Roben (:aroben) 2011-05-12 06:38:03 PDT
Comment on attachment 93221 [details]
[PATCH] Fix with test

r-ing on Sam's behalf.
Comment 4 Brian Weinstein 2011-05-12 09:55:09 PDT
Created attachment 93297 [details]
[PATCH] Fix with faster test
Comment 5 Anders Carlsson 2011-05-12 09:57:59 PDT
Comment on attachment 93297 [details]
[PATCH] Fix with faster test

View in context: https://bugs.webkit.org/attachment.cgi?id=93297&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:84
> +    // Pause will hang the WebProcess long enough to get the processDidBecomeUnresponsive call, and there, we
> +    // reload the page, which restarts the web process. Wait until the page has been reloaded to continue with the test.

This isn't true anymore, is it?
Comment 6 WebKit Review Bot 2011-05-12 09:59:01 PDT
Attachment 93297 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:75:  Tab found; better to use spaces  [whitespace/tab] [1]
Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:79:  Tab found; better to use spaces  [whitespace/tab] [1]
Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:80:  Tab found; better to use spaces  [whitespace/tab] [1]
Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:81:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 4 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Brian Weinstein 2011-05-12 10:00:20 PDT
Comment on attachment 93297 [details]
[PATCH] Fix with faster test

View in context: https://bugs.webkit.org/attachment.cgi?id=93297&action=review

>> Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:84
>> +    // reload the page, which restarts the web process. Wait until the page has been reloaded to continue with the test.
> 
> This isn't true anymore, is it?

Nope. I'll clean up the comment.
Comment 8 Darin Adler 2011-06-18 13:00:04 PDT
r86354