Bug 60657

Summary: SimpleFontData::scaledFontData should return a PassOwnPtr
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60723    
Attachments:
Description Flags
Patch
none
Alternativ Patch (renamed to createScaledFontData) none

Patrick R. Gansterer
Reported 2011-05-11 13:43:10 PDT
SimpleFontData::scaledFontData should return a PassOwnPtr
Attachments
Patch (16.27 KB, patch)
2011-05-11 13:45 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Alternativ Patch (renamed to createScaledFontData) (16.33 KB, patch)
2011-05-11 15:31 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-05-11 13:45:55 PDT
Created attachment 93176 [details] Patch
Alexey Proskuryakov
Comment 2 2011-05-11 15:10:59 PDT
Should the function be renamed to createScaledFontData()?
Patrick R. Gansterer
Comment 3 2011-05-11 15:31:03 PDT
Created attachment 93196 [details] Alternativ Patch (renamed to createScaledFontData) (In reply to comment #2) > Should the function be renamed to createScaledFontData()? Good idea, thx!
Patrick R. Gansterer
Comment 4 2011-05-11 15:32:28 PDT
Comment on attachment 93196 [details] Alternativ Patch (renamed to createScaledFontData) Ooops, missed some changes in patch.
Eric Seidel (no email)
Comment 5 2011-05-11 19:14:23 PDT
Comment on attachment 93176 [details] Patch OK.
Patrick R. Gansterer
Comment 6 2011-05-12 13:50:46 PDT
Comment on attachment 93176 [details] Patch Clearing flags on attachment: 93176 Committed r86375: <http://trac.webkit.org/changeset/86375>
Patrick R. Gansterer
Comment 7 2011-05-12 13:50:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.