Bug 60657

Summary: SimpleFontData::scaledFontData should return a PassOwnPtr
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60723    
Attachments:
Description Flags
Patch
none
Alternativ Patch (renamed to createScaledFontData) none

Description Patrick R. Gansterer 2011-05-11 13:43:10 PDT 
SimpleFontData::scaledFontData should return a PassOwnPtr
Comment 1 Patrick R. Gansterer 2011-05-11 13:45:55 PDT 
Created attachment 93176 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-05-11 15:10:59 PDT 
Should the function be renamed to createScaledFontData()?
Comment 3 Patrick R. Gansterer 2011-05-11 15:31:03 PDT 
Created attachment 93196 [details]
Alternativ Patch (renamed to createScaledFontData)

(In reply to comment #2)
> Should the function be renamed to createScaledFontData()?

Good idea, thx!
Comment 4 Patrick R. Gansterer 2011-05-11 15:32:28 PDT 
Comment on attachment 93196 [details]
Alternativ Patch (renamed to createScaledFontData)

Ooops, missed some changes in patch.
Comment 5 Eric Seidel (no email) 2011-05-11 19:14:23 PDT 
Comment on attachment 93176 [details]
Patch

OK.
Comment 6 Patrick R. Gansterer 2011-05-12 13:50:46 PDT 
Comment on attachment 93176 [details]
Patch

Clearing flags on attachment: 93176

Committed r86375: <http://trac.webkit.org/changeset/86375>
Comment 7 Patrick R. Gansterer 2011-05-12 13:50:55 PDT 
All reviewed patches have been landed.  Closing bug.