Bug 60615

Summary:

[EFL] Remove fixed_layout structure in ewk_view

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

antognolli+webkit, commit-queue, eric, kenneth, lucas.de.marchi, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Proposed Patch	none
Patch	none
Modified Patch	none
Patch	none

Gyuyoung Kim

Reported 2011-05-11 02:38:52 PDT

I don't know why we need to keep fixed_layout structure. We can get the values from ScrollView. I change fixed_layout structure with functions of ScrollView.

Attachments
Proposed Patch (2.82 KB, patch) 2011-05-11 02:41 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (2.81 KB, patch) 2011-05-11 02:46 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Modified Patch (2.93 KB, patch) 2011-05-11 02:59 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (2.91 KB, patch) 2011-05-11 03:07 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2011-05-11 02:41:53 PDT

Created attachment 93093 [details] Proposed Patch

WebKit Review Bot

Comment 2 2011-05-11 02:43:06 PDT

Attachment 93093 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_view.cpp:1134: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 3 2011-05-11 02:46:52 PDT

Created attachment 93095 [details] Patch

Gyuyoung Kim

Comment 4 2011-05-11 02:59:28 PDT

Created attachment 93100 [details] Modified Patch I am sorry. I need to modify this patch a little bit.

WebKit Review Bot

Comment 5 2011-05-11 03:02:36 PDT

Attachment 93100 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ewk/ewk_view.cpp:1139: An else should appear on the same line as the preceding } [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 6 2011-05-11 03:07:11 PDT

Created attachment 93101 [details] Patch

Antonio Gomes

Comment 7 2011-05-11 06:44:22 PDT

Comment on attachment 93101 [details] Patch nice clean up!

WebKit Commit Bot

Comment 8 2011-05-11 07:05:05 PDT

Comment on attachment 93101 [details] Patch Clearing flags on attachment: 93101 Committed r86228: <http://trac.webkit.org/changeset/86228>

WebKit Commit Bot

Comment 9 2011-05-11 07:05:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.