Bug 6061

Summary: Crash on http://me.in-berlin.de/~darwin/svg/incoming/Drawing5.svg
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://me.in-berlin.de/~darwin/svg/incoming/Drawing5.svg
Bug Depends on:    
Bug Blocks: 6074    
Attachments:
Description Flags
Reduced test case.
none
Crasher fix (also cleans up a bit, and fixes other crashers)
darin: review+
Additional test cases and results none

Rob Buis
Reported 2005-12-13 00:26:29 PST
Just load the url into current WebCore+SVG. The backtrace seems to indicate a problem with transforms, but that is just a hunch. Cheers, Rob.
Attachments
Reduced test case. (333 bytes, image/svg+xml)
2005-12-13 00:47 PST, Eric Seidel (no email) 		no flags
Details
Crasher fix (also cleans up a bit, and fixes other crashers) (5.25 KB, patch)
2005-12-13 02:06 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
Additional test cases and results (8.52 KB, patch)
2005-12-13 02:10 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-12-13 00:47:45 PST
Created attachment 5057 [details] Reduced test case. It turns out it's the ending space in a transform declaration which causes the crash: transform="scale(1,1) "
Eric Seidel (no email)
Comment 2 2005-12-13 02:06:05 PST
Created attachment 5058 [details] Crasher fix (also cleans up a bit, and fixes other crashers)
Eric Seidel (no email)
Comment 3 2005-12-13 02:10:39 PST
Created attachment 5059 [details] Additional test cases and results
Eric Seidel (no email)
Comment 4 2005-12-13 02:12:06 PST
Comment on attachment 5058 [details] Crasher fix (also cleans up a bit, and fixes other crashers) Simple, straightforward fix for an easily reproducible crasher.
Darin Adler
Comment 5 2005-12-13 08:06:04 PST
Comment on attachment 5058 [details] Crasher fix (also cleans up a bit, and fixes other crashers) Looks fine. Code could be a lot more terse and slightly easier to read by leaving out the unneeded QString::fromLatin1 calls. Just using a "" string is fine for these plain-ASCII strings, as is QString("") if there's some ambiguity. r=me
Note You need to log in before you can comment on or make changes to this bug.