Bug 60591

Summary: Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eae, eric, hyatt, jamesr, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Levi Weintraub
Reported 2011-05-10 15:38:01 PDT
paintBorder literally constructs and uses an IntRect at the beginning. Let's just take one in :)
Attachments
Patch (19.32 KB, patch)
2011-05-10 16:34 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (19.31 KB, patch)
2011-05-11 11:24 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-05-10 16:34:01 PDT
Created attachment 93046 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-10 17:12:52 PDT
Comment on attachment 93046 [details] Patch This was a good example of tx, ty being just the wrong names for these variables! You may want to run a few pixel tests just to make sure. This looks fine though. the cr-linux EWS runs pixel tests and should catch any failures if you wait for it.
WebKit Review Bot
Comment 3 2011-05-10 17:48:32 PDT
Comment on attachment 93046 [details] Patch Attachment 93046 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8687128
Levi Weintraub
Comment 4 2011-05-11 11:21:09 PDT
(In reply to comment #3) > (From update of attachment 93046 [details]) > Attachment 93046 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/8687128 Missed one "w"! Re-uploading...
Levi Weintraub
Comment 5 2011-05-11 11:24:11 PDT
Created attachment 93149 [details] Patch
Levi Weintraub
Comment 6 2011-05-11 12:06:09 PDT
Cool, fixed the build breakage (how do I love EWS, let me count the ways...)! Eric, can I get that R+ back? ;)
Eric Seidel (no email)
Comment 7 2011-05-11 13:23:09 PDT
Comment on attachment 93149 [details] Patch OK.
Eric Seidel (no email)
Comment 8 2011-05-11 13:23:38 PDT
You should still run a pixel test or two locally to make sure you won't find out you broke things only when the cr-gardener sees them on the bots. :)
Levi Weintraub
Comment 9 2011-05-11 14:33:06 PDT
Comment on attachment 93149 [details] Patch Clearing flags on attachment: 93149 Committed r86272: <http://trac.webkit.org/changeset/86272>
Levi Weintraub
Comment 10 2011-05-11 14:33:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.