Bug 60581

Summary: Don't send zeros in TexImage if GL implementation handles that
Product: WebKit Reporter: John Bauman <jbauman>
Component: WebGLAssignee: John Bauman <jbauman>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, eric, kbr, nduca, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description John Bauman 2011-05-10 14:11:53 PDT 
Don't send zeros in TexImage if GL implementation handles that
Comment 1 John Bauman 2011-05-10 14:48:54 PDT 
Created attachment 93011 [details]
Patch
Comment 2 John Bauman 2011-05-10 16:33:58 PDT 
This fixes http://code.google.com/p/chromium/issues/detail?id=81474 .
Comment 3 Eric Seidel (no email) 2011-05-10 22:22:29 PDT 
I know this is chromium-only, but Simon might want to see this go by.
Comment 4 Kenneth Russell 2011-05-11 12:18:42 PDT 
Comment on attachment 93011 [details]
Patch

If we're going to go down this route then it seems to me that we should just get rid of the texImage2DResourceSafe entry point and fold its functionality into texImage2D. We can rename the current GraphicsContext3D::texImage2D to texImage2DImpl. What do you think?
Comment 5 John Bauman 2011-05-11 12:39:14 PDT 
Sounds reasonable, but maybe other platforms don't always feel the need to fill a new texture with zeros. Say, if they know they're going to be filling it with TexSubImages later.
Comment 6 Kenneth Russell 2011-05-11 12:51:03 PDT 
Comment on attachment 93011 [details]
Patch

OK, fair point. r=me
Comment 7 WebKit Commit Bot 2011-05-11 14:59:07 PDT 
Comment on attachment 93011 [details]
Patch

Clearing flags on attachment: 93011

Committed r86275: <http://trac.webkit.org/changeset/86275>
Comment 8 WebKit Commit Bot 2011-05-11 14:59:12 PDT 
All reviewed patches have been landed.  Closing bug.