Summary: | REGRESSION - Canon On-screen Manual.app crashes after a search | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2011-05-10 12:57:20 PDT
Since the trouble originates in their subclassed dealloc method, we have no idea we're about to be dealloced. We just assume this is a normal [WebView close] and have no way of preventing the retain badness happening at this stage. When the preference is twiddled to allow image loading, there's absolutely no reason why we'd have to start the loads synchronously. Putting that on a 0-delay timer makes this go away which no real side effects. Created attachment 92997 [details]
Patch v1
I committed without the ChangeLog and in-code comment I'd meant to include. Updated with comments in 86180 http://trac.webkit.org/changeset/86180 might have broken Windows XP Debug (Tests) The following tests are not passing: media/controls-without-preload.html (In reply to comment #6) > http://trac.webkit.org/changeset/86180 might have broken Windows XP Debug (Tests) > The following tests are not passing: > media/controls-without-preload.html Appreciate the suggestion, but it's extremely unlikely that adding comments to code broke a layout test. (And almost as unlikely that the original preferences-related patch broke a media test that doesn't invoke that preference) > Appreciate the suggestion, but it's extremely unlikely that adding comments to code broke a layout test. (And almost as unlikely that the original preferences-related patch broke a media test that doesn't invoke that preference)
Yeah, we really need to work on the spaminess of these notifications. Sometimes I'm tempted to turn them off..
@abarth, @beidson: I'll spend some time tomorrow working on making the SB smarter about which bugs it comments on. There is a lot of low hanging fruit here. Adam has turned off notifications when SB would notify more than 3 bugs. I'm not sure if that would have helped here, but it should reduce the times when he's just "spamming". |