Bug 60545

Summary:

Perform some forward declarations suggested by include-what-you-use

Product:

WebKit

Reporter:

Tony Gentilcore <tonyg>

Component:

New Bugs

Assignee:

Tony Gentilcore <tonyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo.noronha, gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

60694

Bug Blocks:

52451

Attachments:

Description	Flags
Patch	gyuyoung.kim: commit-queue-
Patch	none
Patch	none
Patch	darin: review+
Patch	webkit-ews: commit-queue-
Patch	none
Patch	none

Tony Gentilcore

Reported 2011-05-10 05:45:34 PDT

Perform some forward declarations suggested by include-what-you-use

Attachments
Patch (43.95 KB, patch) 2011-05-10 05:46 PDT, Tony Gentilcore	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
Patch (44.44 KB, patch) 2011-05-10 06:17 PDT, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (45.75 KB, patch) 2011-05-10 06:37 PDT, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (46.25 KB, patch) 2011-05-10 07:55 PDT, Tony Gentilcore	darin: review+	Details Formatted Diff Diff
Patch (47.36 KB, patch) 2011-05-11 02:51 PDT, Tony Gentilcore	webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch (47.92 KB, patch) 2011-05-11 07:59 PDT, Tony Gentilcore	no flags	Details Formatted Diff Diff
Patch (47.94 KB, patch) 2011-05-12 02:46 PDT, Tony Gentilcore	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Tony Gentilcore

Comment 1 2011-05-10 05:46:04 PDT

Created attachment 92940 [details] Patch

WebKit Review Bot

Comment 2 2011-05-10 05:48:53 PDT

Attachment 92940 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 67 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2011-05-10 05:59:45 PDT

Comment on attachment 92940 [details] Patch Attachment 92940 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8648862

Tony Gentilcore

Comment 4 2011-05-10 06:17:58 PDT

Created attachment 92945 [details] Patch

WebKit Review Bot

Comment 5 2011-05-10 06:20:36 PDT

Attachment 92945 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 6 2011-05-10 06:24:33 PDT

Comment on attachment 92940 [details] Patch Attachment 92940 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8645900

Collabora GTK+ EWS bot

Comment 7 2011-05-10 06:27:09 PDT

Comment on attachment 92940 [details] Patch Attachment 92940 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8645902

Tony Gentilcore

Comment 8 2011-05-10 06:37:30 PDT

Created attachment 92947 [details] Patch

WebKit Review Bot

Comment 9 2011-05-10 06:39:31 PDT

Attachment 92947 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 70 files If any of these errors are false positives, please file a bug against check-webkit-style.

Collabora GTK+ EWS bot

Comment 10 2011-05-10 07:44:40 PDT

Comment on attachment 92947 [details] Patch Attachment 92947 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8660980

Tony Gentilcore

Comment 11 2011-05-10 07:55:14 PDT

Created attachment 92955 [details] Patch

WebKit Review Bot

Comment 12 2011-05-10 08:10:53 PDT

Attachment 92955 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 71 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 13 2011-05-10 10:25:18 PDT

Comment on attachment 92955 [details] Patch Looks great. As long as it still builds these changes are just right.

Tony Gentilcore

Comment 14 2011-05-11 02:51:35 PDT

Created attachment 93096 [details] Patch

WebKit Review Bot

Comment 15 2011-05-11 02:53:21 PDT

Attachment 93096 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 16 2011-05-11 03:02:05 PDT

Comment on attachment 93096 [details] Patch Attachment 93096 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8689243

WebKit Review Bot

Comment 17 2011-05-11 04:20:19 PDT

Comment on attachment 93096 [details] Patch Attachment 93096 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8684374

Tony Gentilcore

Comment 18 2011-05-11 07:59:55 PDT

Created attachment 93117 [details] Patch

WebKit Review Bot

Comment 19 2011-05-11 08:02:03 PDT

Attachment 93117 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tony Gentilcore

Comment 20 2011-05-12 02:46:10 PDT

Created attachment 93272 [details] Patch

WebKit Review Bot

Comment 21 2011-05-12 02:48:20 PDT

Attachment 93272 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/page/DOMTimer.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/loader/ResourceLoader.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tony Gentilcore

Comment 22 2011-05-12 03:32:07 PDT

Committed r86325: <http://trac.webkit.org/changeset/86325>

Note You need to log in before you can comment on or make changes to this bug.