Bug 60545

Summary: Perform some forward declarations suggested by include-what-you-use
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo.noronha, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 60694    
Bug Blocks: 52451    
Attachments:
Description Flags
Patch
gyuyoung.kim: commit-queue-
Patch
none
Patch
none
Patch
darin: review+
Patch
webkit-ews: commit-queue-
Patch
none
Patch none

Description Tony Gentilcore 2011-05-10 05:45:34 PDT 
Perform some forward declarations suggested by include-what-you-use
Comment 1 Tony Gentilcore 2011-05-10 05:46:04 PDT 
Created attachment 92940 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-10 05:48:53 PDT 
Attachment 92940 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 67 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2011-05-10 05:59:45 PDT 
Comment on attachment 92940 [details]
Patch

Attachment 92940 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8648862
Comment 4 Tony Gentilcore 2011-05-10 06:17:58 PDT 
Created attachment 92945 [details]
Patch
Comment 5 WebKit Review Bot 2011-05-10 06:20:36 PDT 
Attachment 92945 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Gyuyoung Kim 2011-05-10 06:24:33 PDT 
Comment on attachment 92940 [details]
Patch

Attachment 92940 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8645900
Comment 7 Collabora GTK+ EWS bot 2011-05-10 06:27:09 PDT 
Comment on attachment 92940 [details]
Patch

Attachment 92940 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8645902
Comment 8 Tony Gentilcore 2011-05-10 06:37:30 PDT 
Created attachment 92947 [details]
Patch
Comment 9 WebKit Review Bot 2011-05-10 06:39:31 PDT 
Attachment 92947 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 70 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Collabora GTK+ EWS bot 2011-05-10 07:44:40 PDT 
Comment on attachment 92947 [details]
Patch

Attachment 92947 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8660980
Comment 11 Tony Gentilcore 2011-05-10 07:55:14 PDT 
Created attachment 92955 [details]
Patch
Comment 12 WebKit Review Bot 2011-05-10 08:10:53 PDT 
Attachment 92955 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 71 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Darin Adler 2011-05-10 10:25:18 PDT 
Comment on attachment 92955 [details]
Patch

Looks great. As long as it still builds these changes are just right.
Comment 14 Tony Gentilcore 2011-05-11 02:51:35 PDT 
Created attachment 93096 [details]
Patch
Comment 15 WebKit Review Bot 2011-05-11 02:53:21 PDT 
Attachment 93096 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 73 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Early Warning System Bot 2011-05-11 03:02:05 PDT 
Comment on attachment 93096 [details]
Patch

Attachment 93096 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8689243
Comment 17 WebKit Review Bot 2011-05-11 04:20:19 PDT 
Comment on attachment 93096 [details]
Patch

Attachment 93096 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8684374
Comment 18 Tony Gentilcore 2011-05-11 07:59:55 PDT 
Created attachment 93117 [details]
Patch
Comment 19 WebKit Review Bot 2011-05-11 08:02:03 PDT 
Attachment 93117 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 20 Tony Gentilcore 2011-05-12 02:46:10 PDT 
Created attachment 93272 [details]
Patch
Comment 21 WebKit Review Bot 2011-05-12 02:48:20 PDT 
Attachment 93272 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/notifications/NotificationCenter.h:46:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/page/DOMTimer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedCSSStyleSheet.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/loader/ResourceLoader.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Tony Gentilcore 2011-05-12 03:32:07 PDT 
Committed r86325: <http://trac.webkit.org/changeset/86325>