Bug 60535

Summary:

Web Inspector: there is a problem with computed style properties with wrong values

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
screenshot	none
Testcase	none
Patch	yurys: review-
Patch with test	none

Ilya Tikhonovsky

Reported 2011-05-10 00:29:53 PDT

Created attachment 92925 [details] screenshot If the property of a rule has wrong value, as example text-decoration with value normal then computed style pane will show this property as applied but actually the previous was applied.

Attachments
screenshot (155.92 KB, image/png) 2011-05-10 00:29 PDT, Ilya Tikhonovsky	no flags	Details
Testcase (272 bytes, text/html) 2011-05-25 12:02 PDT, tonistiigi	no flags	Details
Patch (1.83 KB, patch) 2011-05-25 12:03 PDT, tonistiigi	yurys: review-	Details Formatted Diff Diff
Patch with test (5.76 KB, patch) 2011-05-28 06:10 PDT, tonistiigi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

tonistiigi

Comment 1 2011-05-25 12:02:14 PDT

Created attachment 94827 [details] Testcase

tonistiigi

Comment 2 2011-05-25 12:03:29 PDT

Created attachment 94828 [details] Patch

Alexander Pavlov (apavlov)

Comment 3 2011-05-25 13:35:05 PDT

Comment on attachment 94828 [details] Patch Looks good. I have a similar fix in my pending rewrite of the StylesSidebarPane (hopefully, it will become much more readable). It's a good idea to have a test for this change.

Yury Semikhatsky

Comment 4 2011-05-26 07:13:53 PDT

According to Alexander it should be fairly easy to test this, you could extend existing test: LayoutTests\inspector\styles\styles-computed-trace.html

Yury Semikhatsky

Comment 5 2011-05-26 07:14:06 PDT

Comment on attachment 94828 [details] Patch r- for now.

tonistiigi

Comment 6 2011-05-28 06:10:25 PDT

Created attachment 95259 [details] Patch with test

WebKit Commit Bot

Comment 7 2011-05-28 10:55:29 PDT

Comment on attachment 95259 [details] Patch with test Clearing flags on attachment: 95259 Committed r87617: <http://trac.webkit.org/changeset/87617>

WebKit Commit Bot

Comment 8 2011-05-28 10:55:35 PDT

All reviewed patches have been landed. Closing bug.

Alexander Pavlov (apavlov)

Comment 9 2011-05-28 13:02:24 PDT

Comment on attachment 95259 [details] Patch with test Looks good. Thanks for the test, Tonis!

Alexander Pavlov (apavlov)

Comment 10 2011-05-28 13:08:49 PDT

Comment on attachment 95259 [details] Patch with test Ouch, I didn't realize the patch had landed.

Note You need to log in before you can comment on or make changes to this bug.