| Summary: | Web Inspector: there is a problem with computed style properties with wrong values | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 94827 [details]
Testcase
Created attachment 94828 [details]
Patch
Comment on attachment 94828 [details]
Patch
Looks good. I have a similar fix in my pending rewrite of the StylesSidebarPane (hopefully, it will become much more readable). It's a good idea to have a test for this change.
According to Alexander it should be fairly easy to test this, you could extend existing test: LayoutTests\inspector\styles\styles-computed-trace.html Comment on attachment 94828 [details]
Patch
r- for now.
Created attachment 95259 [details]
Patch with test
Comment on attachment 95259 [details] Patch with test Clearing flags on attachment: 95259 Committed r87617: <http://trac.webkit.org/changeset/87617> All reviewed patches have been landed. Closing bug. Comment on attachment 95259 [details]
Patch with test
Looks good. Thanks for the test, Tonis!
Comment on attachment 95259 [details]
Patch with test
Ouch, I didn't realize the patch had landed.
|
Created attachment 92925 [details] screenshot If the property of a rule has wrong value, as example text-decoration with value normal then computed style pane will show this property as applied but actually the previous was applied.