Summary: | Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | WebKit Misc. | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ademar, mitz | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2011-05-09 12:37:35 PDT
Created attachment 92832 [details]
Patch
Comment on attachment 92832 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92832&action=review > Source/WebKit/mac/WebView/WebFullScreenController.mm:275 > + WebView* webView = [self webView]; > + NSWindow* webWindow = [webView window]; This doesn’t follow our usual style of putting the * in the traditional place for Objective-C classes. > Source/WebKit/mac/WebView/WebFullScreenController.mm:292 > + // In Lion, NSWindow will animate into and out of orderOut operations. Supress that Extra space here after period. Misspelling of suppress. > Source/WebKit/mac/WebView/WebFullScreenController.mm:531 > + NSWindow* webWindow = [[self webView] window]; Same style issue here. > Source/WebKit/mac/WebView/WebFullScreenController.mm:533 > + // In Lion, NSWindow will animate into and out of orderOut operations. Supress that Same mistakes here. > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:256 > + NSWindow* webWindow = [_webViewPlaceholder.get() window]; > +#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) > + // In Lion, NSWindow will animate into and out of orderOut operations. Supress that Same issue again. Committed r86107: <http://trac.webkit.org/changeset/86107> Revision r86107 cherry-picked into qtwebkit-2.2 with commit 6fe6792 <http://gitorious.org/webkit/qtwebkit/commit/6fe6792> |