Summary: | Style fix: Function names must begin with lowercase letter. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, mitz, shishir | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 54181 | ||||||||
Attachments: |
|
Description
Tony Gentilcore
2011-05-09 08:49:30 PDT
Created attachment 92796 [details]
Patch
Comment on attachment 92796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92796&action=review > Source/WebCore/page/PageVisibilityState.h:47 > #if ENABLE(PAGE_VISIBILITY_API) > -String GetPageVisibilityStateString(PageVisibilityState); > +String getPageVisibilityStateString(PageVisibilityState); > #endif If your intent is to fix to match WebKit project style, then the name should be: pageVisibilityStateString We only use “get” in functions with out arguments; functions that simply return a value use noun or adjective phrases. Created attachment 92797 [details]
Patch
Comment on attachment 92797 [details] Patch Clearing flags on attachment: 92797 Committed r86069: <http://trac.webkit.org/changeset/86069> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 92797 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch. |