Summary: | [Qt] Some skipped editing tests actually work and just need rebaseline. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||
Component: | Tools / Tests | Assignee: | Chang Shu <cshu> | ||||
Status: | RESOLVED LATER | ||||||
Severity: | Normal | CC: | ademar, commit-queue, eric, laszlo.gombos, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 60479, 60498, 60702, 60707, 60717, 61075 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Chang Shu
2011-05-09 08:26:01 PDT
editing/inserting/4278698.html The above test works. Ossy, can you help to rebaseline it? Thanks. editing/inserting/editable-html-element.html this one works, too. and this: editing/inserting/editing-empty-divs.html and this: editing/inserting/insert-div-023.html and this: editing/inserting/multiple-lines-selected.html editing/pasteboard/smart-paste-008.html editing/pasteboard/nested-blocks-with-text-area.html editing/pasteboard/nested-blocks-with-text-field.html editing/pasteboard/input-field-1.html editing/pasteboard/4806874.html editing/pasteboard/5387578.html editing/pasteboard/bad-placeholder.html editing/pasteboard/4076267.html editing/pasteboard/4076267-2.html editing/pasteboard/block-wrappers-necessary.html editing/pasteboard/paste-text-001.html editing/pasteboard/4242293-1.html these two work out-of-box. just upskip them. editing/pasteboard/paste-text-008.html editing/pasteboard/paste-text-at-tabspan-001.html editing/pasteboard/onpaste-text-html-types.html These two also work fine. Unskip. Created attachment 93009 [details]
fix patch: part 1
Comment on attachment 93009 [details]
fix patch: part 1
r=me
The commit-queue encountered the following flaky tests while processing attachment 93009 [details]: http/tests/xmlhttprequest/basic-auth.html bug 51613 (authors: ap@webkit.org and eric@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 93009 [details] fix patch: part 1 Clearing flags on attachment: 93009 Committed r86235: <http://trac.webkit.org/changeset/86235> All reviewed patches have been landed. Closing bug. more patches coming... Generally we do one-patch per-bug and use meta bugs. Then again, you're welcome to use bugzilla however you wish. :) Our tools are obviously optimized for hte one-patch-per-bug workflow. (In reply to comment #25) > Generally we do one-patch per-bug and use meta bugs. Then again, you're welcome to use bugzilla however you wish. :) Our tools are obviously optimized for hte one-patch-per-bug workflow. Thanks, Eric. I understand. This bug is slightly special. You can consider it a meta bug. But since it's just rebaseline, I didn't plan to create separate bugs for each patch. It also takes time to investigate each test case, so I can't do everything in one patch. But if this confuses people, I will create separate bugs in the future. We had some changes in our DRT on trunk and it's not "safe" to cherry-pick layout tests to qtwebkit-2.2 anymore (not without auditing the changes). I'm removing them from the meta-bug (they were not critical anyway, just a nice-to-have). This task can be resumed later. |