Bug 60442

Summary:

REGRESSION (r85795): platform/win/plugins/window-geometry-initialized-before-set-window.html and platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release (WebKit2 Tests)

Product:

WebKit

Reporter:

Jessie Berlin <jberlin>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, andersca, aroben, darin, eric, jberlin, webkit.review.bot

Priority:

Keywords:

InRadar, LayoutTestFailure, PlatformOnly, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

Windows 7

Attachments:

Description	Flags
Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows	andersca: review+

Jessie Berlin

Reported 2011-05-07 16:58:13 PDT

http://trac.webkit.org/changeset/85795 http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r85794%20(6495)/results.html http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r85795%20(6496)/results.html

Attachments
Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows (19.90 KB, patch) 2011-05-10 08:44 PDT, Adam Roben (:aroben)	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jessie Berlin

Comment 1 2011-05-07 17:58:40 PDT

I am going to commit the expected failing results in order to get the bots green.

Jessie Berlin

Comment 2 2011-05-07 18:35:18 PDT

Committed the expected failing results in http://trac.webkit.org/changeset/86019

Jessie Berlin

Comment 3 2011-05-07 18:35:44 PDT

<rdar://problem/9403200>

Adam Roben (:aroben)

Comment 4 2011-05-09 06:03:18 PDT

Big ol' fail on my part. Thanks for cleaning up the mess, Jessie. I'll look into these failures today.

Adam Roben (:aroben)

Comment 5 2011-05-09 06:55:57 PDT

I think we can relax these tests such that they still pass in WebKit2 and would start failing if either of the bugs they are tests for were reintroduced. At this point I see no evidence that they are indicative of real-world bugs in WebKit2.

Adam Roben (:aroben)

Comment 6 2011-05-10 07:55:38 PDT

platform/win/plugins/window-geometry-initialized-before-set-window.html is easy to fix. We should just check the window's size and stop caring about its position. platform/win/plugins/window-region-is-set-to-clip-rect.html is harder. In WebKit2, the plugin window's region won't be set until the UI process paints. But we don't have a good way to wait for that to happen, or to ensure that it happens in a certain order.

Adam Roben (:aroben)

Comment 7 2011-05-10 08:32:12 PDT

(In reply to comment #6) > platform/win/plugins/window-region-is-set-to-clip-rect.html is harder. In WebKit2, the plugin window's region won't be set until the UI process paints. But we don't have a good way to wait for that to happen, or to ensure that it happens in a certain order. A timer seems to work around the issue. (Lame!)

Adam Roben (:aroben)

Comment 8 2011-05-10 08:44:06 PDT

Created attachment 92959 [details] Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows

Adam Roben (:aroben)

Comment 9 2011-05-10 08:53:12 PDT

Committed r86157: <http://trac.webkit.org/changeset/86157>

WebKit Review Bot

Comment 10 2011-05-10 10:53:27 PDT

http://trac.webkit.org/changeset/86157 might have broken SnowLeopard Intel Release (WebKit2 Tests) The following tests are not passing: fast/frames/flattening/frameset-flattening-subframesets.html

Note You need to log in before you can comment on or make changes to this bug.