Bug 60433

Summary: Web Inspector: REGRESSION metrics editing doesn't applies to the element
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   

Description Ilya Tikhonovsky 2011-05-07 00:31:11 PDT
Metrics side bar panel.
Comment 1 Alexander Pavlov (apavlov) 2011-05-07 01:55:37 PDT
What does "does not apply" mean in this context? The element's inline style does not receive the altered box properties? The visual model is not guaranteed to change once these properties are applied (e.g. for position: static elements).
Comment 2 Ilya Tikhonovsky 2011-05-07 02:09:07 PDT
(In reply to comment #1)
> What does "does not apply" mean in this context? The element's inline style does not receive the altered box properties? The visual model is not guaranteed to change once these properties are applied (e.g. for position: static elements).

the entered value doesn't appear in the element's style property and there is no visual changes in the inspected page.

I saw the next error in the inspector's inspector console:

Uncaught TypeError: Object #<MouseEvent> has no method 'getPropertyValue'
WebInspector.MetricsSidebarPane.editingCommitted
DevTools.js:16538
boundDevTools.js:12
editingCommittedDevTools.js:3449
handleEditingResultDevTools.js:3468
keyDownEventListener

the line:
 if (computedStyle.getPropertyValue("box-sizing") === "border-box" && (styleProperty === "width" || styleProperty === "height")) {
Comment 3 Alexander Pavlov (apavlov) 2011-05-07 04:50:24 PDT
Which revision of webkit is this?
Comment 4 Alexander Pavlov (apavlov) 2011-05-07 04:53:15 PDT
Just to clarify, I believe the issue was fixed in r84481 (a parameter added to the this.startEditing.bind() call)