Bug 60422

Summary: Add details to leveldb "internal error" message
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED INVALID    
Severity: Normal CC: hans
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
use pointer, not reference none

David Grogan
Reported 2011-05-06 17:38:59 PDT
Add details to leveldb "internal error" message
Attachments
Patch (5.60 KB, patch)
2011-05-06 17:40 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
use pointer, not reference (5.61 KB, patch)
2011-05-06 18:07 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2011-05-06 17:40:21 PDT
Created attachment 92664 [details] Patch
David Grogan
Comment 2 2011-05-06 18:07:47 PDT
Created attachment 92669 [details] use pointer, not reference
Eric Seidel (no email)
Comment 3 2011-05-08 12:55:17 PDT
Comment on attachment 92669 [details] use pointer, not reference Why can't we test this in an automated fashion?
David Grogan
Comment 4 2011-05-09 11:06:42 PDT
Optimally we would. But spending a few days adding a bunch of test infrastructure for leveldb probably isn't worth the benefit of ensuring that internal error messages are correct. It'd be great if we already had a way of testing leveldb, but we're still working on it (crbug.com/81382). Given the small size of this change and the difficulty in testing, could you re-consider?
Eric Seidel (no email)
Comment 5 2011-12-19 11:01:55 PST
Comment on attachment 92669 [details] use pointer, not reference Cleared review? from attachment 92669 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.