Bug 60407

Summary: IndexedDB: add detail to an ASSERT error message
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hans, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

David Grogan
Reported 2011-05-06 14:58:53 PDT
IndexedDB: add detail to an ASSERT error message
Attachments
Patch (1.33 KB, patch)
2011-05-06 14:59 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (1.36 KB, patch)
2011-05-12 11:05 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2011-05-06 14:59:14 PDT
Created attachment 92646 [details] Patch
Hans Wennborg
Comment 2 2011-05-09 02:29:16 PDT
Looks good to me.
Eric Seidel (no email)
Comment 3 2011-05-11 19:39:26 PDT
Comment on attachment 92646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92646&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This will cause the cq to fail. You should just explain why testing isn't needed or possible. In this case, because this is just a debug ASSERT. :)
David Grogan
Comment 4 2011-05-12 11:04:16 PDT
Comment on attachment 92646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92646&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests. (OOPS!) > > This will cause the cq to fail. You should just explain why testing isn't needed or possible. In this case, because this is just a debug ASSERT. :) Thanks, I'll update. The cq will fail if the changelog entry includes "No new tests."? Or "(OOPS!)"? Or both?
David Grogan
Comment 5 2011-05-12 11:05:24 PDT
Created attachment 93307 [details] Patch
David Grogan
Comment 6 2011-06-17 15:32:16 PDT
Eric, could you take another look at this?
David Grogan
Comment 7 2011-06-22 21:23:12 PDT
(Actually cc'ing Eric this time) Eric, could you take another look at this?
Eric Seidel (no email)
Comment 8 2011-06-22 23:39:23 PDT
Comment on attachment 93307 [details] Patch OK.
WebKit Review Bot
Comment 9 2011-06-23 00:20:50 PDT
Comment on attachment 93307 [details] Patch Clearing flags on attachment: 93307 Committed r89541: <http://trac.webkit.org/changeset/89541>
WebKit Review Bot
Comment 10 2011-06-23 00:20:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.