| Summary: | [GTK] Enable Media Stream feature and make it default on | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Bergkvist <adam.bergkvist> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, mrobinson, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 60174, 60391 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Adam Bergkvist
2011-05-06 12:14:53 PDT
Created attachment 92623 [details]
Proposed patch
It'd be easier to review this patch if you provided a bit of context about the media stream feature and why it's good to have it default to enabled. :) (In reply to comment #2) > It'd be easier to review this patch if you provided a bit of context about the media stream feature and why it's good to have it default to enabled. :) We are implementing "chapter 9" in the WHATWG HTML specification - Video conferencing and peer-to-peer communication (http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication). Other people seem to be doing some work in this area as well and we want to make sure that whatever code that is added works on GTK and passes the tests. Thus we would like to enable this feature by default to have the build bots run the tests. Is this feature complete or experimental? If it's experimental and you want to run tests on the bots, we should at least default it to off in configure.ac. That will ensure that people compiling our releases, won't be automatically saddled with an incomplete, perhaps buggy feature. Created attachment 93097 [details]
Updated patch
Yes you're right. This feature is incomplete and experimental and should be turned off by default in configure.ac.
Comment on attachment 93097 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=93097&action=review > configure.ac:573 > + [enable media stream support (incomplete) [default=no]]), When landing please change this to say "(experimental)" here to match the other flags. Adam is not a committer, so unless you're asking him to upload a new patch Martin, we should either r- this or cq+ it. (In reply to comment #7) > Adam is not a committer, so unless you're asking him to upload a new patch Martin, we should either r- this or cq+ it. I think that incomplete is probably fine here in place of experimental. Comment on attachment 93097 [details] Updated patch Clearing flags on attachment: 93097 Committed r89227: <http://trac.webkit.org/changeset/89227> All reviewed patches have been landed. Closing bug. |