Bug 60392

Summary:

Leopard Intel Release (NRWT) shouldn't be a core builder

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Exclude the Leopard NRWT bot from the core builder set	darin: review+

Description Adam Roben (:aroben) 2011-05-06 11:49:16 PDT

Leopard Intel Release (NRWT) is currently a core builder. But we don't currently expect it to be green. It's more a proof-of-concept bot to help us shake out NRWT issues. So we should remove it from the core set.

Comment 1 Dirk Pranke 2011-05-06 20:08:37 PDT

I'm totally fine with this. what needs to be done to make it non-core?

Comment 2 Eric Seidel (no email) 2011-05-08 14:02:49 PDT

Yeah, I don't think anyone has any objections, just no one has bothered to do it yet. :)

The core builders code (which is old!) is here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py#L287

For whatever reason when I added the core builder code I copied the regexps to the unittests (I think I though it made the tests more explicit, but mostly its just confused people).  They're here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py#L273

Both need to be changed.

Comment 3 Adam Roben (:aroben) 2011-05-13 08:00:28 PDT

Created attachment 93453 [details]
Exclude the Leopard NRWT bot from the core builder set

Comment 4 Adam Roben (:aroben) 2011-05-13 10:40:31 PDT

Committed r86445: <http://trac.webkit.org/changeset/86445>