Bug 60374

Summary: Adding parameters to ScheduleChildWindowGeometryUpdate message is tedious
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: PlatformAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 60285    
Attachments:
Description Flags
Patch andersca: review+

Adam Roben (:aroben)
Reported 2011-05-06 09:20:39 PDT
Adding parameters to ScheduleChildWindowGeometryUpdate message is tedious
Attachments
Patch (21.93 KB, patch)
2011-05-06 09:21 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-05-06 09:21:26 PDT
Created attachment 92588 [details] Patch
WebKit Review Bot
Comment 2 2011-05-06 09:24:06 PDT
Attachment 92588 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/win/WindowGeometry.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2011-05-06 10:31:07 PDT
Committed r85958: <http://trac.webkit.org/changeset/85958>
Note You need to log in before you can comment on or make changes to this bug.