Bug 60369
| Summary: | [Qt] QtWebKit test fonts should support Hebrew fonts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chang Shu <cshu> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | hausmann, laszlo.gombos, marcelo.lira, ossy, pierre.rossi, s.mathur, vestbo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Chang Shu
The current test fonts downloaded from git://gitorious.org/qtwebkit/testfonts.git do not have support for displaying Hebrew fonts. At least, the following test is failing because of this:
editing/selection/extend-selection-bidi.html
We should make effort to add the support to test fonts.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chang Shu
msttcorefonts supports hebrew. I am not sure if it makes sense to switch to it. It could be an external dependency.
http://corefonts.sourceforge.net/
Laszlo Gombos
I tend to agree with Chang. Chromium is using msttcorefonts on Linux - see http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites. This might also give us perhaps some opportunities to share expected results with Chromium.
Simon Hausmann
Sounds like a good idea to me. We can't redistribute those fonts, but making them an external dependency should be a no-brainer.
Marcelo Lira
The missing hebrew fonts have been added to the testfonts repository.
Commit f11a54548121ee9fb0688dc6f32acdbfec5d2d2f
More details in the commit message:
https://gitorious.org/qtwebkit/testfonts/commit/f11a54548121ee9fb0688dc6f32acdbfec5d2d2f/diffs