Bug 60345

Summary:

EWS can't reject patches

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Adam Barth

Reported 2011-05-06 00:00:09 PDT

Traceback (most recent call last): File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 108, in run if not self._delegate.process_work_item(work_item): File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/commands/queues.py", line 378, in process_work_item if not self.review_patch(patch): File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py", line 149, in review_patch self._post_reject_message_on_bug(self._tool, patch, task.failure_status_id, self._failing_tests_message(task, patch)) File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py", line 109, in _post_reject_message_on_bug tool.bugs.set_flag_on_attachment(patch.bug_id(), "commit-queue", "-", message, extra_message_text) File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 631, in set_flag_on_attachment self.browser.set_value(comment_text, name='comment', nr=0) File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 2823, in set_value c = self.find_control(name, type, kind, id, label=label, nr=nr) File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 3101, in find_control return self._find_control(name, type, kind, id, label, predicate, nr) File "/mnt/git/webkit-chromium-ews/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 3185, in _find_control raise ControlNotFoundError("no control matching "+description) ControlNotFoundError: no control matching name 'comment'

Attachments
Patch (2.93 KB, patch) 2011-05-06 00:06 PDT, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-05-06 00:06:29 PDT

Created attachment 92551 [details] Patch

Adam Barth

Comment 2 2011-05-06 00:07:02 PDT

Committed r85922: <http://trac.webkit.org/changeset/85922>

Adam Barth

Comment 3 2011-05-06 00:12:53 PDT

Comment on attachment 92551 [details] Patch I landed this without review because I'm a problem child.

Eric Seidel (no email)

Comment 4 2011-05-06 08:40:24 PDT

Comment on attachment 92551 [details] Patch Lgtm

Note You need to log in before you can comment on or make changes to this bug.