| Summary: | The position of validation message bubble is wrong for non text fields. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||||||||||
| Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | dglazkov, morrita, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 28649 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Kent Tamura
2011-05-05 22:52:39 PDT
Created attachment 92544 [details]
Demo and images
Created attachment 92564 [details]
Patch
Comment on attachment 92564 [details] Patch Attachment 92564 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8608022 New failing tests: fast/forms/validation-message-appearance-textarea.html fast/forms/validation-message-appearance-checkbox.html fast/forms/validation-message-appearance-menulist.html fast/forms/validation-message-appearance-radio.html fast/forms/validation-message-appearance.html fast/forms/validation-message-appearance-listbox.html Created attachment 92592 [details]
Archive of layout-test-results from ec2-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 93076 [details]
Patch 2
Update test_expectations.txt too.
Comment on attachment 93076 [details] Patch 2 Attachment 93076 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8687213 New failing tests: fast/forms/validation-message-appearance.html Created attachment 93077 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 93076 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=93076&action=review Just for curious: Is it reasonable to use Markup.dump() helper JS function to dump shadow DOM tree, instead of dump the render tree? I think using pixel tests is OK, but shadow tree is essentially about DOM so we can possibly do more DOM centric approach for testing. > Source/WebCore/html/ValidationMessage.cpp:142 > ExceptionCode ec = 0; It might be nice if we had separate getter function for the bubble position. Created attachment 93089 [details]
Patch 3
Converted to text dump
Comment on attachment 93076 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=93076&action=review Markup.dump() is not enough because the purpose of these tests is to check the position of validation message bubbles. I thought dumpAsText() didn't work because we had no perfect way to obtain a validation message bubble node under ShadowRoot. The bubble node is always the last child of ShadowRoot for now, but it might be changed. I changed the mind. Updating test code in the future is better than maintaining pixel tests. >> Source/WebCore/html/ValidationMessage.cpp:142 >> ExceptionCode ec = 0; > > It might be nice if we had separate getter function for the bubble position. ok, I move the code to a separated function though it's not a getter. Comment on attachment 93089 [details]
Patch 3
Looks good.
Comment on attachment 93089 [details] Patch 3 Clearing flags on attachment: 93089 Committed r86224: <http://trac.webkit.org/changeset/86224> All reviewed patches have been landed. Closing bug. |