Bug 60324

Summary: NRWT: remove --print detailed-progress
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, ggaren, mjs, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Dirk Pranke
Reported 2011-05-05 17:18:10 PDT
NRWT: remove --print detailed-progress
Attachments
Patch (17.53 KB, patch)
2011-05-05 17:19 PDT, Dirk Pranke 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-05-05 17:19:34 PDT
Created attachment 92508 [details] Patch
Dirk Pranke
Comment 2 2011-05-05 17:23:26 PDT
At some point (more than a year ago), I added a "--print detailed-progress" option to new-run-webkit-tests to try and emulate the output that old-run-webkit-tests did (printing the directory name followed by a dot at a time for each test). The code was always something of a hack since the default mode (running tests in parallel sharded by directory) can't really be mapped onto that style of output. So, the detailed progress only worked if you weren't running things in parallel at all, or if you were running in "experimental-fully-parallel" mode where we put each test into a shard and did roughly try to run them in order. There was also a fair amount of complexity to handle the tests coming in that way and printing things out. Given the year since, I don't think I've used this feature a single time, and I haven't heard of anyone else using it, either. So, I'd like to remove it.
Adam Barth
Comment 3 2011-05-05 17:43:28 PDT
Comment on attachment 92508 [details] Patch ok
Dirk Pranke
Comment 4 2011-05-27 19:12:50 PDT
Committed as r87593.
Note You need to log in before you can comment on or make changes to this bug.